Skip to content

chore: upgrade surrealdb package to v1.0.0 - #1507

Open
Odonno wants to merge 1 commit into
CommunityToolkit:mainfrom
Odonno:feat/surrealdb-1-0-0
Open

chore: upgrade surrealdb package to v1.0.0#1507
Odonno wants to merge 1 commit into
CommunityToolkit:mainfrom
Odonno:feat/surrealdb-1-0-0

Conversation

@Odonno

@Odonno Odonno commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1507

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1507"

@Odonno
Odonno enabled auto-merge August 3, 2026 13:15
<ItemGroup>
<PackageReference Include="Bogus" />
<PackageReference Include="Microsoft.AspNetCore.OpenApi" />
<PackageReference Include="Microsoft.AspNetCore.OpenApi" VersionOverride="10.0.10" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that we wouldn't bump this in the Directory.Packages.props? If we start using VersionOverrides it becomes a problem trying to keep on top of where versions are coming from (I do acknowledge that this is in the examples project, but once a pattern starts somewhere it spreads).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not want to break the other projects just to upgrade mine. I think there must be a plan to upgrade packages at some point. I can do another PR after to deal with that if you want.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to bump it? Or do we end up with transient dependency collisions if it's not updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants